fix: rename GraphQLExecutor to AbstractGraphQLExecutor #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
The SDK core module offers a set of abstract classes and interfaces that are expected to be implemented by the product SDK. These implementations will act as a "bridge" between the product SDK and the core module. In this PR, the
GraphQLExecutorabstract class got renamed toAbstractGraphQLExecutor, enabling product SDKs to use theGraphQLExecutoras a name for the implementation class. This make the experience more straight forward and expectable.Task
GraphQLExecutorclass toAbstractGraphQLExecutor.DefaultGraphQLExecutortoGraphQLExecutorAction
Renamed the two classes, reflected the changes to all files using these classes.
Testing
All existing tests are passing ✅