Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow additional parser options in the gradle and maven plugins #1925

Merged
merged 1 commit into from
Feb 14, 2024
Merged

feat: allow additional parser options in the gradle and maven plugins #1925

merged 1 commit into from
Feb 14, 2024

Conversation

mgilbey
Copy link
Contributor

@mgilbey mgilbey commented Feb 14, 2024

Enables configuration of the maxCharacters and maxParserDepth parser options for GraphQL Java.

📝 Description

See ParserOptions for the values configured in graphql-java.

🔗 Related Issues

Extensions of #1586 with additional parameters that have been added to graphql-java.

@samuelAndalon samuelAndalon merged commit 8ebf3c9 into ExpediaGroup:master Feb 14, 2024
9 checks passed
@mgilbey mgilbey deleted the moreParserOptions branch February 16, 2024 09:59
@dariuszkuc dariuszkuc added the changes: minor Changes require a minor version label Feb 19, 2024
@dariuszkuc dariuszkuc mentioned this pull request Feb 19, 2024
Merged
samuelAndalon pushed a commit that referenced this pull request Feb 22, 2024
@mgilbey
fix: allow maven and gradle plugins to have new parser options values…
0aea13e 
… configurable (#1930)

### 📝 Description

Previous val declaration for the additional parser options cannot be
reassigned - they should be a var and not val.

### 🔗 Related Issues

#1925
#1586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelAndalon samuelAndalon samuelAndalon approved these changes

Assignees
No one assigned
Labels
changes: minor Changes require a minor version
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgilbey @samuelAndalon @dariuszkuc