Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix feature view retrieval and add timestamp field to schema #94

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix: Fix feature view retrieval and add timestamp field to schema #94

merged 2 commits into from
Mar 13, 2024

Conversation

EXPEbdodla
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
Minor fixes when validating Streaming Ingestion

  • HTTP Registry has no support for Stream Feature View so switching the default check to feature view
  • Timestamp columns in feature view are not part of the schema so explicitly adding them so we don't delete from data frames
  • changing print statement to logger

@EXPEbdodla EXPEbdodla merged commit be6b236 into master Mar 13, 2024
17 checks passed
@EXPEbdodla EXPEbdodla deleted the stream_ingest_fixes branch March 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanitabhagwat vanitabhagwat vanitabhagwat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EXPEbdodla @vanitabhagwat