Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handles null values in data during the retrieval #93

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

EXPEbdodla
Copy link
Collaborator

@EXPEbdodla EXPEbdodla commented Mar 10, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

  1. Null values are materialized as &types.Value{} instead of nil
  2. Added logging when http error occurs
  3. Ran go formatting

Other observations #

  1. Null values inside arrays are not supported by Materialization
    • INT32, INT64 columns are upcasted to float64 when Null value exists in array. So it fails with invalid type error
    • String arrays fail materialization
    • Materialization works for float, double and timestamp. It's stored as Nan. On Go server side, json encoding not converting NaN to None.
    • Feature server retrieval (GO) doesn't work for float, double
    • Materialization defaults timestamp so its working in Feature server

We need to fix this if necessary

@EXPEbdodla EXPEbdodla changed the title fix: Handles Nil or Null.NULL Value fix: Handles null values in data during the retrieval Mar 10, 2024
@EXPEbdodla EXPEbdodla merged commit 1763d8d into master Mar 13, 2024
19 checks passed
@EXPEbdodla EXPEbdodla deleted the fix_Null_value_proto branch March 13, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants