Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refreshes the registry instead of stopping the background refresh #89

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: Refreshes the registry instead of stopping the background refresh #89

merged 2 commits into from
Mar 7, 2024

Conversation

EXPEbdodla
Copy link
Collaborator

@EXPEbdodla EXPEbdodla commented Mar 6, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

  • When error occurs, return statement stop the goroutine. So registry won't refresh.

@EXPEbdodla EXPEbdodla merged commit c540117 into master Mar 7, 2024
17 checks passed
@EXPEbdodla EXPEbdodla deleted the fix_go_registry_refresh branch March 7, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wparsley-eg wparsley-eg wparsley-eg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EXPEbdodla @wparsley-eg