try closing the process inside the process definition, don't have the…

… parent wait.
ExpediaGroup · Oct 6, 2023 · f1fe084 · f1fe084
1 parent c8fefec
commit f1fe084
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/go/internal/feast/transformation/transformation.go b/go/internal/feast/transformation/transformation.go
@@ -169,15 +169,12 @@ func CallTransformations(
 				transformResp <- TransformChannel{outRecord, nil}
 			}
 		}
+		p.Close()
 	})
 	resp := <-transformResp
 	if resp.err != nil {
 		return nil, resp.err
 	}
-	err := proc.Close()
-	if err != nil {
-		return nil, err
-	}
 
 	result := make([]*onlineserving.FeatureVector, 0)
 	for idx, field := range resp.outRecord.Schema().Fields() {

diff --git a/go/internal/feast/transformation/transformation_test.go b/go/internal/feast/transformation/transformation_test.go
@@ -40,7 +40,7 @@ func createOnDemandFeatureView(name string, featureSources map[string][]*core.Fe
 	return model.NewOnDemandFeatureViewFromProto(proto)
 }
 
-func TestCallTransformations(t *testing.T) {
+func TestCallTransformationsFailsWithError(t *testing.T) {
 	featASpec := createFeature("featA", prototypes.ValueType_INT32)
 	featBSpec := createFeature("featB", prototypes.ValueType_INT32)
 	onDemandFeature1 := createFeature("featC", prototypes.ValueType_FLOAT)