Skip to content

Commit

Permalink
fix: Enable registry cache on transformations server (#77)
Browse files Browse the repository at this point in the history
* Try enabling the cache in transformations server

* product

* fix import

* add opentracing as python dependency; try tracing

* tear out opentracing; try ddtrace

* put getenv back into featurestore.go

* tracing for ddog analysis

* fix go compilation warning

* fix ddog import

* timing transformation functions

* remove debug output

* try removing datadog pin override

* cleanup

* linting

---------

Co-authored-by: William Parsley <[email protected]>
  • Loading branch information
wparsley-eg and William Parsley authored Feb 2, 2024
1 parent cd72009 commit 89d9ad5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sdk/python/feast/transformation_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def GetTransformationServiceInfo(self, request, context):
def TransformFeatures(self, request, context):
try:
odfv = self.fs.get_on_demand_feature_view(
request.on_demand_feature_view_name
name=request.on_demand_feature_view_name, allow_cache=True
)
except OnDemandFeatureViewNotFoundException:
context.set_code(grpc.StatusCode.INVALID_ARGUMENT)
Expand All @@ -210,6 +210,7 @@ def TransformFeatures(self, request, context):

def start_server(store: FeatureStore, port: int):
log.info("Starting server..")

server = grpc.server(futures.ThreadPoolExecutor(max_workers=10))
add_TransformationServiceServicer_to_server(TransformationServer(store), server)

Expand Down

0 comments on commit 89d9ad5

Please sign in to comment.