Skip to content

Commit

Permalink
Merge pull request #28 from ExpediaGroup/debug_apply
Browse files Browse the repository at this point in the history
fixc linting
  • Loading branch information
piket authored Aug 31, 2023
2 parents d2e2071 + b7409d7 commit 33b16ce
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
10 changes: 7 additions & 3 deletions sdk/python/feast/feature_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,8 @@ def apply(
... )
>>> fs.apply([driver_hourly_stats_view, driver]) # register entity and feature view
"""
print(f"Apply with: {objects}") #TODO: remove
# TODO: remove
print(f"Apply with: {objects}")
# TODO: Add locking
if not isinstance(objects, Iterable):
objects = [objects]
Expand Down Expand Up @@ -992,12 +993,15 @@ def apply(
tables_to_delete: List[FeatureView] = views_to_delete + sfvs_to_delete if not partial else [] # type: ignore
tables_to_keep: List[FeatureView] = views_to_update + sfvs_to_update # type: ignore

print(f"""Update project={self.project},
# TODO: remove
print(
f"""Update project={self.project},
tables_to_delete={tables_to_delete},
tables_to_keep={tables_to_keep},
entities_to_delete={entities_to_delete if not partial else []},
entities_to_keep={entities_to_update},
partial={partial},""") #TODO: remove
partial={partial},"""
)
self._get_provider().update_infra(
project=self.project,
tables_to_delete=tables_to_delete,
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/passthrough_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ def update_infra(
):
set_usage_attribute("provider", self.__class__.__name__)

print(f"Is online store={self.online_store}") #TODO: remove
# TODO: remove
print(f"Is online store={self.online_store}")
# Call update only if there is an online store
if self.online_store:
self.online_store.update(
Expand Down

0 comments on commit 33b16ce

Please sign in to comment.