Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-generator): Set attribute datatype to typing.Any if missing. #270

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix(docs-generator): Set attribute datatype to typing.Any if missing. #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions expediagroup/sdk/docsgen/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ def from_(other: docspec.Variable) -> Attribute:
if not other:
raise ValueError(str(other))

if not other.datatype:
other.datatype = str(Any)

return Attribute(
name=other.name,
datatype=other.datatype,
Expand Down
4 changes: 2 additions & 2 deletions expediagroup/sdk/generator/client/templates/__model__.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{# See the License for the specific language governing permissions and#}
{# limitations under the License.#}
{{ model_imports }}
from typing import Union, Any, Literal
from typing import Union, Any, Literal, Callable
from pydantic import Extra, validator, SecretStr, SecretBytes
from pydantic.dataclasses import dataclass
from expediagroup.sdk.core.model.exception.service import ExpediaGroupApiException
Expand All @@ -22,7 +22,7 @@ SecretStr.__str__ = lambda self: '<-- omitted -->' if self.get_secret_value() el
class PydanticModelConfig:
r"""List of configurations for all SDK pydantic models."""

JSON_ENCODERS = {
JSON_ENCODERS: dict[type, Callable] = {
SecretStr: lambda v: v.get_secret_value() if v else None,
SecretBytes: lambda v: v.get_secret_value() if v else None,
}
Expand Down