test: performance testing for sdk core #865
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
The
sdk-core
package is well-covered by unit tests that validate its functionality. However, we currently lack performance tests/benchmarks to evaluate and ensure that our SDKs meet modern performance standards, in addition to being functionally correct.Task
Benchmarking Tool
Real-World Scenario Simulation
Focus Areas
Comprehensive Reporting
Load and Stress Testing
Action
We have engineered a solution for benchmarking the
sdk-core
, designed to perform comprehensive load and stress testing while closely replicating real-world environments to ensure accurate and meaningful performance insights.Initial Setup
We have created a new module in the repository root named
performance-test
. It is worth mentioning that new GitHub actions will be proposed to consume the newly proposed module and perform benchmarks with thesdk-core
package as target.Mock Server
To mimic real-world scenarios, we will be depending on a mock service using Specmatic. Specmatic will consume the
openapi.yaml
spec file. The mock server will be setup in future GitHub actions.To run the mock server locally, follow the following steps:
performance-test
module.cd performance-test/src/main/resources
openapi.yaml
file as contract and thespecmatic-data
directory as request-response data, optionally on port8080
.java -jar $specmatc stub openapi.yaml --data specmatic-data --port 8080
The
specmatic-data
directory content will define the responses Specmatic mock server will return. In this case, we have defined allJSON
responses to have a length of~1e7
characters. Any files returned by Spematic mock server (in case of download operation) will be an image of size nearly0.5MB
.Sample SDK
We introduced a custom OpenAPI spec file which includes a few endpoints and operations based on the type of operations we currently support in our SDK core. The spec includes the following endpoints:
GET /text
: Get operation endpoint which returns a text response withapplication/json
as the content type.POST /text
: POST operation endpoint which accepts a text body (Message) and returns a text response withapplication/json
as the content type.GET /files
: Get operation endpoint which can be used to download a file withimage/png
as the content type.The spec file was also used to generate a sample, tweaked SDK, which is then used in the benchmark process. The SDK has multiple clients based on their authentication algorithm, along with their different configurations and builders. Currently, we have 2 SDK clients:
BasicAuthBasedClient
EanAuthBasedClient
Benchmarks
We have evaluated established performance testing frameworks such as Apache Jmeter and Gatling. While these frameworks offer robust features, they also come with inherent limitations and complexities that did not fully align with our specific requirements. Consequently, we opted to adopt a streamlined, custom in-house and simple approach tailored to our current needs.
Benchmark API
We have established a standardized contract in the form of an interface,
PerformanceTestClient
, for SDK clients to be benchmarked.The contract is closely aligned with and centered around the
openapi.yaml
specification file, ensuring consistency, acting as a bridge, facilitating seamless integration and interaction between the SDK clients and the benchmark API.The API also defines contracts which help extending benchmark targets and differentiate between the
sync
andasync
benchmarking models such as:Benchmarked
: A representation of a scenario or operation to be benchmarked synchronously.AsyncBenchmarked
: A representation of a scenario or operation to be benchmarked asynchronously.Both the aforementioned contracts also contain metadata about each benchmark individual unit, such as:
name
: Name of the benchmark.description
: Optional description if needed.repeat
: How many times to run the executable/target and collect execution results.timeout
andtimeoutUnit
: Both define amount of time to fail the benchmark in case the execution time exceeds the defined timeout value.Benchmark Engine
We have developed a robust and extensible benchmarking engine designed to evaluate SDK operations and scenarios based on the pre-defined
sdk-core
contracts. The engine is both flexible and simple, supporting both synchronous (sync
) and asynchronous (async
) benchmarking models. It is capable of managing and tracking a virtually unlimited number of requests, regardless of the concurrency model, while ensuring precise and accurate performance metrics.Each successful benchmark operation will produce a report, which in its simplest form, includes information about the benchmark final results such as:
name
: Name of the benchmark.description
: Optional description.startTime
-endTime
: Zoned data and time of the start and end of the benchmark.executionsCount
: The amount of times the benchmark target executable was executed.duration
: Total consumed time in benchmarking.averageExecutionTime
: Average time consumed per single execution.Benchmark Reports
At the end of all benchmarks, results are collected and a report is generated in the form of a table. We used picnic to fetch data into a table-like structure. Sample:
Once the report is rendered, it is persisted to disk.
Command-Line-Interface (CLI)
A CLI is set in-place for ease-of-use, which can trigger the execution of all the benchmarks, producing a report which is written on disk. The CLI can be called as follows:
mvn clean install exec:java -Dexec.args="--output report.txt"
Testing
TBA
Results
We now possess a comprehensive set of utilities to effectively benchmark our
sdk-core
, enabling us to accurately simulate and evaluate performance under real-world scenarios with precision and reliability.Notes
We are not yet supporting file uploads, multipart requests and/or other HTTP related operations, for that we only benchmark what our
sdk-core
supports at the moment.A futuristic idea that was mentioned by @mohnoor94, which basically suggest that we run performance tests/benchmarks per pull-request, and add a comment on the pull-request with the final report.
This was unplanned for, but maybe we might want to include more information in the final report, such as:
We might want to render the report into other formats, such as
Markdown
,JSON
,YAML
or others.