-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SDK-1568 expose okhttp client as a configuration in sdk core #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtayeh
force-pushed
the
dtayeh/SDK-1568
branch
2 times, most recently
from
November 20, 2024 15:03
1e3eec7
to
c8f5281
Compare
mohnoor94
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing the solution offline, we agreed to introduce a new builder that includes only the supported configurations, ensuring compatibility with the new okHttpClient
settings and eliminating the need to throw exceptions.
dtayeh
force-pushed
the
dtayeh/SDK-1568
branch
7 times, most recently
from
November 25, 2024 10:25
1688f14
to
c518e82
Compare
mohnoor94
requested changes
Nov 25, 2024
core/src/main/kotlin/com/expediagroup/sdk/core/client/BaseRapidClient.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/expediagroup/sdk/core/client/OkHttpEventListener.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/expediagroup/sdk/core/client/OkHttpEventListener.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/expediagroup/sdk/core/client/OkHttpEventListener.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/expediagroup/sdk/core/client/OkHttpEventListener.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/expediagroup/sdk/core/client/OkHttpEventListener.kt
Show resolved
Hide resolved
core/src/main/kotlin/com/expediagroup/sdk/core/client/Client.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/expediagroup/sdk/core/client/BaseRapidClient.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/expediagroup/sdk/core/client/BaseRapidClient.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/expediagroup/sdk/core/client/BaseRapidClient.kt
Outdated
Show resolved
Hide resolved
mohnoor94
approved these changes
Nov 25, 2024
mohnoor94
previously approved these changes
Nov 25, 2024
dtayeh
force-pushed
the
dtayeh/SDK-1568
branch
from
November 26, 2024 09:58
f490b70
to
94a88f3
Compare
dtayeh
force-pushed
the
dtayeh/SDK-1568
branch
2 times, most recently
from
November 26, 2024 13:02
d9c16a0
to
26c0df4
Compare
dtayeh
force-pushed
the
dtayeh/SDK-1568
branch
from
November 26, 2024 13:05
26c0df4
to
2f270d8
Compare
mohnoor94
previously approved these changes
Nov 26, 2024
dtayeh
force-pushed
the
dtayeh/SDK-1568
branch
3 times, most recently
from
November 26, 2024 15:34
6fec878
to
b0fbff5
Compare
mohnoor94
previously approved these changes
Nov 26, 2024
dtayeh
force-pushed
the
dtayeh/SDK-1568
branch
from
November 26, 2024 15:54
b0fbff5
to
c59a4d6
Compare
anssari1
approved these changes
Nov 26, 2024
mohnoor94
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
Some users of the RAPID SDK are interested in getting more control over the underlying httpClient used by the SDK, such as tuning the dispatcher concurrency configs, or injecting interceptors/eventlisteners for monitoring purposes
Task
Enable users to inject their own okhttp client when configuring the SDK client.
Action
Testing
Manual testing by running the rapid examples covering test-cases:
Results
Users are able to build and inject a custom okhttp client to be used by the SDK for executing requests.