feat: Kafka cloud provider support #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f parameters to fill only with prefix params
…f parameters to fill only with prefix params
…f parameters to fill only with prefix params
…f parameters to fill only with prefix params
…f parameters to fill only with prefix params
feat: adding config properties map for kafka consumer
patduin
reviewed
Nov 4, 2024
drone-fly-app/pom.xml
Outdated
| <dependency> | ||
| <groupId>software.amazon.msk</groupId> | ||
| <artifactId>aws-msk-iam-auth</artifactId> | ||
| <version>1.1.1</version> |
There was a problem hiding this comment.
Can we move to 1.1.9? It has some vulnerability fixes.
patduin
reviewed
Nov 4, 2024
drone-fly-integration-tests/pom.xml
Outdated
| <dependency> | ||
| <groupId>software.amazon.msk</groupId> | ||
| <artifactId>aws-msk-iam-auth</artifactId> | ||
| <version>1.1.1</version> |
There was a problem hiding this comment.
same here, also add a property for it in the parent pom so we have the number in one place
Upgrading msk iam version to 1.1.9
patduin
previously approved these changes
Nov 6, 2024
patduin
approved these changes
Nov 6, 2024
mroark1m
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Related Issues