Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set default connector jar path #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: set default connector jar path #129

wants to merge 2 commits into from

Conversation

githubjianli
Copy link
Collaborator

📝 Description

Fixed

  • Set default AUX_CLASSPATH based on MYSQL_TYPE.
    • When mysql, then set to /usr/share/java/mysql-connector-java.jar.
    • When mariadb then set to /usr/share/java/mariadb-connector-java.jar.
    • Else set to MYSQL_DRIVER_JAR.

🔗 Related Issues

@githubjianli githubjianli requested a review from a team as a code owner June 21, 2024 17:37
patduin
patduin requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@patduin patduin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need this, please hold off merging this for now.

@javsanbel2
Copy link
Contributor

This was fixed here #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patduin patduin patduin requested changes

@DhrubajyotiSadhu DhrubajyotiSadhu DhrubajyotiSadhu approved these changes

@mroark1m mroark1m mroark1m approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@githubjianli @javsanbel2 @mroark1m @patduin @DhrubajyotiSadhu @JianLi-Expedia