feat: added support to use mysql jdbc driver #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroark1m
previously approved these changes
Jun 18, 2024
jmnunezizu
reviewed
Jun 18, 2024
| @@ -3,6 +3,12 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [4.1.0] - 2024-06-19 | |||
| ### Added | |||
| - Added `MYSQL_CONNECTION_DRIVER_NAME` to support use different connection driver, defaults: `com.mysql.jdbc.Driver`. | |||
There was a problem hiding this comment.
Should this be a major version release? Changing the driver from Maria to MySQL could be a breaking change.
There was a problem hiding this comment.
they are actually same, but we just trying to make it make better sense, so mariadb is using mariabdb connector jar, mysql is using mysql jar, so I think this is a minor change.
There was a problem hiding this comment.
isn't someone using MariaDB RDS moving to this version now suddenly using the mysql driver? Maybe a major version makes sense here.
patduin
approved these changes
Jun 19, 2024
javsanbel2
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
MYSQL_CONNECTION_DRIVER_NAMEto support use different connection driver, defaults:com.mysql.jdbc.Driver.MYSQL_TYPEto support use different type of MySQL, defaults:mysql.mysql-connector-javato support to use drivercom.mysql.jdbc.Driver.🔗 Related Issues