Added capability to choose Connection Pooling driver and specify it's configuration #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us_connection_pooling_type`, `hms_ro_datanucleus_connection_pool_config`, `hms_rw_datanucleus_connection_pool_config`, `hms_housekeeper_db_connection_pool_size` variables to allow specifying the pooling driver and its config
…ig and var.hms_rw_datanucleus_connection_pool_config
patduin
reviewed
Jun 26, 2024
patduin
reviewed
Jun 26, 2024
CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [7.10.0] - 2024-06-26 | |||
javsanbel2
reviewed
Jun 26, 2024
| name = "DATANUCLEUS_CONNECTION_POOLING_TYPE" | ||
| value = var.hms_rw_datanucleus_connection_pooling_type | ||
| } | ||
| env { |
There was a problem hiding this comment.
Why do we have DATANUCLEUS_CONNECTION_POOL_MAX_POOLSIZE setting but at the same time we add dynamically connection pool configuration? should not be this part of the dynamic configuration?
There was a problem hiding this comment.
I thought about it a lot. It can be but it should not be. It is way too important and can be missed. We need to add an explicit setting for the pool size.
There was a problem hiding this comment.
this setting by the way is shared across all pool types as well, so it's safe to make it explicit.
javsanbel2
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
hms_ro_datanucleus_connection_pooling_type,hms_rw_datanucleus_connection_pooling_type,hms_ro_datanucleus_connection_pool_config,hms_rw_datanucleus_connection_pool_config,hms_housekeeper_db_connection_pool_sizevariables to allow specifying the pooling driver and its config📝 Description
🔗 Related Issues