Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added var to set copy_tag_to_snapshot. Fixes issue #17 #260

Merged
merged 1 commit into from
May 22, 2024

Conversation

patduin
Copy link
Contributor

@patduin patduin commented May 22, 2024

No description provided.

@patduin patduin requested a review from a team as a code owner May 22, 2024 13:48
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [7.1.5] - 2024-05-22
### Fixed
- Add `copy_tags_to_snapshot` to aws_rds_cluster.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the previous change to provider version made this a setting with default to false. At least that's what the latest version has: https://registry.terraform.io/providers/hashicorp/aws/5.50.0/docs/resources/rds_cluster#copy_tags_to_snapshot
Older version docs are not available.

So overriding cause all our clusters have this by default to true.

@patduin patduin merged commit cddd0a5 into master May 22, 2024
2 checks passed
@patduin patduin deleted the feature/rds_copy_tag_to_snapshots branch May 22, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants