Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed datadog secret key default value #253

Merged
merged 4 commits into from
Apr 3, 2024
Merged

fix: fixed datadog secret key default value #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
828da60
fix: changed datadog_key_secret_name default value
JianLi-Expedia Apr 2, 2024
cc3d768
fix: fixed typo
JianLi-Expedia Apr 2, 2024
999dfd3
Update CHANGELOG.md
JayGreeeen Apr 3, 2024
aa103a5
Update CHANGELOG.md
JayGreeeen Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [7.1.1] - 2024-04-03
### Fixed
- Renamed variable from `common_producer_iamroles` to `apiary_common_producer_iamroles` to make the name consistent.
- Change default value for `datadog_key_secret_name` from `null` to `""`.

## [7.1.0] - 2024-03-21
### Added
- Added `common_producer_iamroles` to allow roles read-write access to all Apiary managed schemas.
Expand Down
2 changes: 1 addition & 1 deletion VARIABLES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
| atlas\_cluster\_name | Name of the Atlas cluster where metastore plugin will send DDL events. Defaults to `var.instance_name` if not set. | `string` | `""` | no |
| atlas\_kafka\_bootstrap\_servers | Kafka instance url. | `string` | `""` | no |
| aws\_region | AWS region. | `string` | n/a | yes |
| common\_producer\_iamroles | AWS IAM roles allowed general (not tied to schema) write access to managed Apiary S3 buckets. | `list(string)` | `[]` | no |
| apiary\_common\_producer\_iamroles | AWS IAM roles allowed general (not tied to schema) write access to managed Apiary S3 buckets. | `list(string)` | `[]` | no |
| dashboard\_namespace | k8s namespace to deploy grafana dashboard. | `string` | `"monitoring"` | no |
| db\_apply\_immediately | Specifies whether any cluster modifications are applied immediately, or during the next maintenance window. | `bool` | `false` | no |
| db\_backup\_retention | The number of days to retain backups for the RDS Metastore DB. | `string` | n/a | yes |
Expand Down
2 changes: 1 addition & 1 deletion s3.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ locals {
client_roles = replace(lookup(schema, "client_roles", ""), ",", "\",\"")
governance_iamroles = join("\",\"", var.apiary_governance_iamroles)
consumer_prefix_roles = lookup(var.apiary_consumer_prefix_iamroles, schema["schema_name"], {})
common_producer_iamroles = join("\",\"", var.common_producer_iamroles)
common_producer_iamroles = join("\",\"", var.apiary_common_producer_iamroles)
})
}
}
Expand Down
6 changes: 3 additions & 3 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ variable "hms_ro_request_partition_limit" {
variable "datadog_key_secret_name" {
description = "Name of the secret containing the DataDog API key. This needs to be created manually in AWS secrets manager. This is only applicable to ECS deployments."
type = string
default = null
default = ""
}

variable "datadog_agent_version" {
Expand All @@ -734,8 +734,8 @@ variable "datadog_agent_enabled" {
default = false
}

variable "common_producer_iamroles" {
variable "apiary_common_producer_iamroles" {
description = "AWS IAM roles allowed read-write access to managed Apiary S3 buckets."
type = list(string)
default = []
}
}
Loading