fix: add condition on service account creation

ExpediaGroup · Oct 23, 2024 · 0b8a6c6 · 0b8a6c6
1 parent c4d743f
commit 0b8a6c6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [7.5.2] - 2024-10-23
+### Fixed
+- Added condition for `k8s` service account secret creation.
+
 ## [7.5.1] - 2024-10-22
 ### Added
 - Added `apiary_extra_tags_s3` variable to add s3 buckets extra tags.

diff --git a/k8s-service-accounts.tf b/k8s-service-accounts.tf
@@ -10,6 +10,7 @@ resource "kubernetes_service_account_v1" "hms_readwrite" {
 }
 
 resource "kubernetes_secret_v1" "hms_readwrite" {
+  count = var.hms_instance_type == "k8s" ? 1 : 0
   metadata {
     name        = "${local.hms_alias}-readwrite"
     namespace   = var.metastore_namespace
@@ -37,6 +38,7 @@ resource "kubernetes_service_account_v1" "hms_readonly" {
 }
 
 resource "kubernetes_secret_v1" "hms_readonly" {
+  count = var.hms_instance_type == "k8s" ? 1 : 0
   metadata {
     name        = "${local.hms_alias}-readonly"
     namespace   = var.metastore_namespace
@@ -64,6 +66,7 @@ resource "kubernetes_service_account_v1" "s3_inventory" {
 }
 
 resource "kubernetes_secret_v1" "s3_inventory" {
+  count = var.hms_instance_type == "k8s" ? 1 : 0
   metadata {
     name        = "${local.instance_alias}-s3-inventory"
     namespace   = var.metastore_namespace