Skip to content

Commit

Permalink
fix: fixing s3 inventory service account secret (#271)
Browse files Browse the repository at this point in the history
Co-authored-by: janli <[email protected]>
  • Loading branch information
githubjianli and JianLi-Expedia authored Aug 26, 2024
1 parent a2c89c5 commit 085f4cf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [7.3.1] - 2024-08-26
### Fixed
- Fixed incorrect `s3-inventory` service account secret binding.

## [7.3.0] - 2024-08-20
### Added
- If apiary_managed_schemas has `deny_global_write_access` enabled, only `producer_roles` will be able to write in the specified schema.
Expand Down
4 changes: 2 additions & 2 deletions k8s-service-accounts.tf
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ resource "kubernetes_service_account_v1" "s3_inventory" {

resource "kubernetes_secret_v1" "s3_inventory" {
metadata {
name = "${local.hms_alias}-s3-inventory"
name = "${local.instance_alias}-s3-inventory"
namespace = var.metastore_namespace
annotations = {
"kubernetes.io/service-account.name" ="${local.hms_alias}-s3-inventory"
"kubernetes.io/service-account.name" ="${local.instance_alias}-s3-inventory"
"kubernetes.io/service-account.namespace" = var.metastore_namespace
}
}
Expand Down

0 comments on commit 085f4cf

Please sign in to comment.