Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forward timeout in .each() #11

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix: forward timeout in .each() #11

merged 2 commits into from
Oct 3, 2024

Conversation

sparten11740
Copy link
Contributor

timeout was previously not honored in cases like below:

test.each([1,2,3])('case %s', (number) => {}, 10_000)

@sparten11740 sparten11740 self-assigned this Oct 3, 2024
@ChALkeR ChALkeR merged commit e589b9d into main Oct 3, 2024
9 checks passed
@mvayngrib
Copy link
Contributor

@ChALkeR can you release this? 🙏

@sparten11740
Copy link
Contributor Author

and maybe also include #12 if it looks good?

@sparten11740
Copy link
Contributor Author

also mind configuring automatic head branch deletion on PR merge?

@sparten11740 sparten11740 deleted the sparten11740/fix/timeout-on-each branch October 11, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees

@sparten11740 sparten11740

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sparten11740 @mvayngrib @ChALkeR