Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't declare dist as binary #55

Merged

Conversation

sparten11740
Copy link
Collaborator

There's a bug in git 2.46.x preventing git diff --exit-code or git diff --quiet exiting with a non-zero exit code when there is a diff in a file declared as binary in .gitattributes. This will effectively disable our CI check to make sure that the action has been built and committed.

@sparten11740 sparten11740 self-assigned this Sep 20, 2024
@sparten11740 sparten11740 enabled auto-merge (squash) September 23, 2024 13:14
@sparten11740 sparten11740 merged commit e049557 into master Oct 8, 2024
2 checks passed
@sparten11740 sparten11740 deleted the sparten11740/chore/dont-declare-dist-as-binary branch October 8, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants