feat: configurable default branch #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboucquez
reviewed
Feb 14, 2024
src/version.ts
Outdated
| @@ -44,6 +44,7 @@ export default async function version({ | |||
| autoMerge = core.getInput(Input.AutoMerge) === 'true', | |||
| requestReviewers = core.getInput(Input.RequestReviewers) === 'true', | |||
| assignee = core.getInput(Input.Assignee), | |||
| defaultBranch = core.getInput(Input.DefaultBranch), | |||
There was a problem hiding this comment.
Is this picked from github config? Nice...
aka, just need to bump, not to provide main
There was a problem hiding this comment.
no, this is actually an input for the action named default-branch. But I like your idea of getting it from the repo metadata.
There was a problem hiding this comment.
changed to get the default branch from the repo in 471623b, will do a test in our test repo before merging though
There was a problem hiding this comment.
tested and found to work: https://github.com/ExodusMovement/lerna-version-selectively/actions/runs/7902671055/job/21568828434
mvayngrib
approved these changes
Feb 14, 2024
sparten11740
deleted the
sparten11740/feat/configurable-default-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the default branch against which PRs are created configurable (for assets where
mainis the default branch)