fix: schnorrSign return type and type and signature #176
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboucquez
requested review from
kewde,
diegomura and
mvayngrib
as code owners
fboucquez
force-pushed
the
fboucquez/fix/keychain-signSchnorr-type
branch
from
3bc9ab5
to
de35100
Compare
fboucquez
force-pushed
the
fboucquez/fix/keychain-signSchnorr-type
branch
from
de35100
to
287dba4
Compare
mvayngrib
reviewed
Nov 15, 2024
| @@ -49,7 +49,7 @@ export const create = ({ getPrivateHDKey }) => { | |||
| ) | |||
| const hdkey = getPrivateHDKey({ seedId, keyId }) | |||
| const privateKey = tweak ? tweakPrivateKey({ hdkey, tweak }) : hdkey.privateKey | |||
| return secp256k1.schnorrSign({ data, privateKey, extraEntropy }) | |||
| return Buffer.from(await secp256k1.schnorrSign({ data, privateKey, extraEntropy })) | |||
There was a problem hiding this comment.
Suggested change
| return Buffer.from(await secp256k1.schnorrSign({ data, privateKey, extraEntropy })) | |
| return secp256k1.schnorrSign({ data, privateKey, extraEntropy, format: 'buffer' }) |
There was a problem hiding this comment.
nice, i didn't know about that param
andrewtoth
reviewed
Nov 15, 2024
features/keychain/api/index.d.ts
Outdated
| @@ -34,6 +34,7 @@ export interface KeychainApi { | |||
| secp256k1: { | |||
| signBuffer(params: { data: Buffer } & KeySource): Promise<Buffer> | |||
| signBuffer(params: { data: Buffer; enc: 'der' } & KeySource): Promise<Buffer> | |||
| signSchnorr(params: { data: Buffer; extraEntropy?: Buffer } & KeySource): Promise<Buffer> | |||
There was a problem hiding this comment.
I added this already in #174.
But, if we want to use this one, for consistency we should not add the extraEntropy param (or add for all), and we need the tweak?: Buffer param.
There was a problem hiding this comment.
your PR can land too, it adds other api types
There was a problem hiding this comment.
Ok, I merged so you will have to rebase here. I think if we're adding extraEntropy? we should add for the other signBuffer signatures too.
feri42
previously approved these changes
Nov 15, 2024
fboucquez
force-pushed
the
fboucquez/fix/keychain-signSchnorr-type
branch
from
3176f69
to
f9a05e1
Compare
mvayngrib
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing schnorrSign ts type and fixes the return type to be
Bufferrather than justUint8Arrayfor consistency