fix(keychain)!: only export secret if "exportPrivate" flag is set #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoskichel
requested review from
kewde,
diegomura and
mvayngrib
as code owners
mvayngrib
changed the title
mvayngrib
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
keychainmodule so thatkeychain.sodium.getSodiumKeysFromSeedonly returns thesecretkey whenexportSecretis set.Context
The
secretkey holds the symmetric-key encryption key used inlibsodiumto both encrypt and decrypt messages, therefore its very sensitive data and shouldn't be exposed unless in very specific situations.Closes: #136