Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade slip10 to fix esm #127

Merged
merged 2 commits into from
Aug 16, 2024
Merged

fix: upgrade slip10 to fix esm #127

merged 2 commits into from
Aug 16, 2024

Conversation

mvayngrib
Copy link
Collaborator

@mvayngrib mvayngrib commented Jul 26, 2024

Test Plan

thanks @ChALkeR for the issue and test plan

import { fromMasterSeed as bip32FromMasterSeed } from '@exodus/bip32'
import SLIP10 from '@exodus/slip10'

const MAP_KDF = Object.freeze({
  BIP32: bip32FromMasterSeed,
  SLIP10: SLIP10.fromSeed,
})

console.log(Object.entries(MAP_KDF))

before: [ [ 'BIP32', [Function: fromMasterSeed] ], [ 'SLIP10', undefined ] ]
after: [ [ 'BIP32', [Function: fromMasterSeed] ], [ 'SLIP10', [Function: fromSeed] ] ]

@@ -32,6 +32,7 @@ const untranspiledModulePatterns = [
'@exodus/dependency-preprocessors',
'@exodus/osmosis-*',
'@exodus/key-utils',
'@exodus/slip10',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest yells at me otherwise about not allowed to use import outside of a module

@mvayngrib mvayngrib marked this pull request as ready for review July 26, 2024 12:38
@ChALkeR
Copy link
Contributor

ChALkeR commented Jul 26, 2024

Will re-test

Copy link
Contributor

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's land this

@@ -2148,6 +2148,17 @@ __metadata:
languageName: node
linkType: hard

"@exodus/slip10@npm:^2.0.0":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we dedup?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we need to upgrade key-ids -> keychain first

Copy link
Contributor

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@fboucquez fboucquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mvayngrib mvayngrib merged commit 5658119 into master Aug 16, 2024
8 checks passed
@mvayngrib mvayngrib deleted the mv/bump-slip10 branch August 16, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants