-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade slip10 to fix esm #127
Conversation
@@ -32,6 +32,7 @@ const untranspiledModulePatterns = [ | |||
'@exodus/dependency-preprocessors', | |||
'@exodus/osmosis-*', | |||
'@exodus/key-utils', | |||
'@exodus/slip10', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jest yells at me otherwise about not allowed to use import outside of a module
Will re-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's land this
@@ -2148,6 +2148,17 @@ __metadata: | |||
languageName: node | |||
linkType: hard | |||
|
|||
"@exodus/slip10@npm:^2.0.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we dedup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we need to upgrade key-ids -> keychain first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Test Plan
thanks @ChALkeR for the issue and test plan
before:
[ [ 'BIP32', [Function: fromMasterSeed] ], [ 'SLIP10', undefined ] ]
after:
[ [ 'BIP32', [Function: fromMasterSeed] ], [ 'SLIP10', [Function: fromSeed] ] ]