-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOF-7417: consider non-collinear case while parsing qe bandstructure #146
Conversation
@@ -23,7 +23,7 @@ dependencies = [ | |||
# "rdkit-pypi>=2022.3.5", | |||
"jarvis-tools>=2023.12.12", | |||
# To avoid module 'numpy.linalg._umath_linalg' has no attribute '_ilp64' in Colab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timurbazhirov what is the numpy version requirement for Colab? There are some breaking (minor) changes on numpy v2 (recently released). For now, we may pin to numpy v1. Also, numpy now requires Python v3.9 or above. Tests are failing on v3.8, because it cannot install numpy v1.26.0. If Colab compatibility allows, we may pin to v1.24.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's just use "numpy<2" and let pip figure it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including @knc6 - any insight regarding the numpy version for Colab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root of the problem appears to be presence of multiple numpy versions in the system numpy/numpy#25150 Colab comes with preinstalled set of python packages, including numpy. As of now, Colab uses the latest release of numpy v1. So, with current range specification, we are good for now. But the problem might come back when Colab upgrades to numpy v2 and we are not. We can fix our code in a separate PR, so that we can use numpy v2 as well.
cc7b30d
to
ac25885
Compare
There are more breaking changes on numpy v2:
See - numpy/numpy#26710 |
3678a85
to
09c8294
Compare
No description provided.