Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOF-7136: property manifest for Hubbard V nearest neighbors #284

Merged
merged 4 commits into from
Dec 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions example/properties_directory/non-scalar/hubbard_v.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,18 @@
{
"id": 1,
"atomicSpecies": "Co",
"orbitalName": "3d",
"id2": 1,
"atomicSpecies2": "Co",
"orbitalName2": "3d",
"distance": 0,
"value": 6.7553
},
{
"distance": 0.0,
"value": 7.7514
},
{
"id": 1,
"atomicSpecies": "Co",
"orbitalName": "3d",
"id2": 2,
"id2": 19,
"atomicSpecies2": "O",
"orbitalName2": "3p",
"distance": 3.5423,
"value": 2.2438
}
"distance": 3.630748,
"value": 0.7573
}
]
}
24 changes: 24 additions & 0 deletions example/properties_directory/non-scalar/hubbard_v_nn.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"name": "hubbard_v_nn",
"units": "eV",
"values": [
{
"id": 1,
"atomicSpecies": "Co",
"orbitalName": "3d",
"id2": 1,
"atomicSpecies2": "Co",
"orbitalName2": "3d",
"value": 7.7514
},
{
"id": 1,
"atomicSpecies": "Co",
"orbitalName": "3d",
"id2": 19,
"atomicSpecies2": "O",
"orbitalName2": "2p",
"value": 0.7573
}
]
}
6 changes: 6 additions & 0 deletions manifest/properties.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -269,3 +269,9 @@ hubbard_v:
units: eV
schemaId: properties-directory/non-scalar/hubbard-v
isResult: true

hubbard_v_nn:
defaults:
units: eV
schemaId: properties-directory/non-scalar/hubbard-v-nn
isResult: true
2 changes: 1 addition & 1 deletion schema/core/reusable/atomic_data/per_orbital_pair.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"distance": {
"type": "number",
"description": "Distance between two sites in angstrom."
"description": "Distance between two sites in Bohr."
}
}
}
2 changes: 1 addition & 1 deletion schema/properties_directory/non-scalar/hubbard_u.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$id": "properties-directory/non-scalar/hubbard-u",
"$schema": "http://json-schema.org/draft-04/schema#",
"title": "Hubbard U parameters",
"description": "Hubbard U value in eV",
"description": "Hubbard U values in eV corresponding to atomic species, orbital and site number.",
"properties": {
"name": {
"enum": ["hubbard_u"]
Expand Down
4 changes: 2 additions & 2 deletions schema/properties_directory/non-scalar/hubbard_v.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"$id": "properties-directory/non-scalar/hubbard-v",
"$schema": "http://json-schema.org/draft-04/schema#",
"title": "Hubbard V parameters",
"description": "Hubbard V value in eV",
"description": "Hubbard V values corresponding to atomic pairs",
"properties": {
"name": {
"enum": ["hubbard_v"]
"enum": ["hubbard_v", "hubbard_v_nn"]
},
"units": {
"enum": ["eV"]
Expand Down
11 changes: 11 additions & 0 deletions schema/properties_directory/non-scalar/hubbard_v_nn.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"$id": "properties-directory/non-scalar/hubbard-v-nn",
"$schema": "http://json-schema.org/draft-04/schema#",
"title": "Hubbard V parameters for nearest neighbors",
"description": "Hubbard V value in eV for nearest neighbors used in hp.x output parsing",
"allOf": [
{
"$ref": "hubbard_v.json"
}
]
}
Loading