SOF-6896: more adjustments to psp and pseudopotential file schemas #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| "exchangeCorrelation": { | ||
| "data": { |
There was a problem hiding this comment.
It should just have valenceConfiguration added
| "categories": { | ||
| "tier1": "qm", | ||
| "tier2": "wf", | ||
| "type": "psp", | ||
| "subtype": "paw" | ||
| }, | ||
| "data": [ | ||
| "metaProperties": [ |
There was a problem hiding this comment.
It's good to rename this, but we don't necessarily need to - it will require changes to JS/webapp. Are those changes present as well?
There was a problem hiding this comment.
I think currently we do not have equivalent of psp schema, we are only using psp/file in imports/properties/schemas/pseudo.js.
…hemas" This reverts commit 820ea14.
pranabdas
force-pushed
the
fix/SOF-6896-2
branch
from
4c2fc77 to
8241ef4
Compare
| "items": { | ||
| "description": "Specific data based on pseudopotential file.", | ||
| "$ref": "./psp/file.json" | ||
| "metaProperties": { |
There was a problem hiding this comment.
Let's just keep as it was for now
pranabdas
force-pushed
the
fix/SOF-6896-2
branch
2 times, most recently
from
1b91cbe to
18c3d2a
Compare
pranabdas
force-pushed
the
fix/SOF-6896-2
branch
from
18c3d2a to
6b705d9
Compare
| "data": { | ||
| "type": "array", | ||
| "items": { | ||
| "description": "Specific data based on pseudopotential file.", | ||
| "$ref": "./psp/file.json" | ||
| "type": "object", |
There was a problem hiding this comment.
Let's keep this file as it was
| @@ -0,0 +1,42 @@ | |||
| { | |||
There was a problem hiding this comment.
Should have slug and data here
timurbazhirov
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.