-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOF-6892: include new hubbard parameters property #277
Conversation
f62e3e8
to
b4813e7
Compare
b4813e7
to
7f1c15e
Compare
{ | ||
"name": "hubbard_parameters", | ||
"units": "eV", | ||
"category": "hubbard_u", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we return to reusable atomic_properties
per orbital instead of adding "category"?
# Reusable: atomic_properties_per_orbital
{
"name": "ANY",
"values":
[
{
"id": 1,
"atomicOrbital": {
// reusing the content of "atomicOrbital" here, maybe not all of it
"orbitalName": "3S",
"orbitalIndex": 1,
"principalNumber": 3,
"angularMomentum": 0,
"occupation": 2
},
"value": 6.3
},
{
"id": 1,
"orbitalName": "3S",
"value": 3.3
},
{
"id": 2,
"orbitalName": "3P",
"value": 6.3
}
]
}
Then hubbard_u
is a specific implementation of an atomic_properties_per_orbital
, so is hubbard_v
and hubbard_j
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to decide. Few things to note:
- We have only
orbitalName
in common. Not sure if it is worth reusingatomicOrbital
- It is a per site property (same species on different sites can have different U values). In case of
V
, it is no longer per site rather inter-site property (V Co-3d O-2p 1 2 0.2
), so we are going to have somewhat different schema. - Property names are used in application-flavors/executables/ to specify the results. We do not have different flavors for
hp.x
, so how do we specify when to usehubbard_u
and whenhubbard_v
result? I created category for this (keeping the samename
), which can be populated by the parser depending on the content ofhp.x
output.
@@ -0,0 +1,37 @@ | |||
{ | |||
"name": "hubbard_parameters", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we extract hubbard_u and hubbard_v separately as two different properties? Do we ever need to store both together?
And what about J?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hubbard_u, hubbard_v and hubbard_v_nn (add description full name - nearest neighbors)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, currently hp.x does not support calculating Hubbard parameters based on DFT+U+J.
example/properties_directory/non-scalar/hubbard_parameters.json
Outdated
Show resolved
Hide resolved
example/properties_directory/non-scalar/hubbard_parameters.json
Outdated
Show resolved
Hide resolved
example/properties_directory/non-scalar/hubbard_parameters.json
Outdated
Show resolved
Hide resolved
0ebc996
to
176ec74
Compare
"type": "string", | ||
"pattern": "^[1-7][sSpPdDfF]$" | ||
}, | ||
"distance": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to indicate the required and optional parameters - all but distance should be required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving orbitalName
(s) as non-required as hp.x supports only main orbitals in DFT+U+V calculations, so orbital names can be omitted.
], | ||
"properties": { | ||
"value": { | ||
"type": "number", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably create atomic_data_per_orbital_number
and atomic_data_per_orbital_string
if needed, and then use them here - otherwise, it looks weird to be adding value of type number here directly
} | ||
], | ||
"properties": { | ||
"value": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
1ec3913
to
c08e946
Compare
f240a45
to
e0cefa4
Compare
No description provided.