Feature/SOF-6588 feat: add ConsistencyChecks schema #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "type": "array", | ||
| "items": { | ||
| "type": "object", | ||
| "properties": { |
There was a problem hiding this comment.
Isolate to consistency_check.json
| "key": { | ||
| "type": "string" | ||
| }, | ||
| "checkName": { |
| "$ref": "base.json" | ||
| }, | ||
| { | ||
| "$ref": "../system/consistency_checks.json" |
There was a problem hiding this comment.
Let's just add into the in-memory entity itself as optional key
There was a problem hiding this comment.
That means to the in_memory_entity/base.json
| "title": "consistency checks", | ||
| "properties": { | ||
| "keys": { | ||
| "type": "array", |
There was a problem hiding this comment.
We need to describe what these are
There was a problem hiding this comment.
Might look cumbersome, but outlines the idea: "The output of consistency checks performed on data adhering to JSON schema, but inconsistent with scientific or logical rules, to show problems in UI."
schema/in_memory_entity/base.json
Outdated
| @@ -19,6 +19,12 @@ | |||
| }, | |||
| "systemName": { | |||
| "type": "string" | |||
| }, | |||
| "consistency_checks": { | |||
timurbazhirov
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.