-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOF-6873: include valence configuration in pseudopotential schema #262
Conversation
d7da65a
to
fd586bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, see comments
32783e8
to
4f57789
Compare
}, | ||
"name": { | ||
"type": "string", | ||
"description": "name of the data category: pseudopotential" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is fixed, we can also use
"name": {
"type": "string",
"description": "name of the data category",
"enum": ["pseudopotential"]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
This PR: