Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOF-6873: include valence configuration in pseudopotential schema #262

Merged
merged 9 commits into from
Sep 16, 2023

Conversation

pranabdas
Copy link
Member

@pranabdas pranabdas commented Aug 30, 2023

This PR:

  1. extends pseudo potential schema to include information about atomic orbitals, e.g., orbital names, occupations
  2. added/removed schema fields to match with current web-app implementation
  3. updated example/test data

@pranabdas pranabdas marked this pull request as ready for review September 5, 2023 11:31
Copy link
Contributor

@azech-hqs azech-hqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, see comments

},
"name": {
"type": "string",
"description": "name of the data category: pseudopotential"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is fixed, we can also use

"name": {
    "type": "string",
    "description": "name of the data category",
    "enum": ["pseudopotential"]
}

Copy link
Contributor

@azech-hqs azech-hqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@timurbazhirov timurbazhirov merged commit ba511dd into dev Sep 16, 2023
9 checks passed
@timurbazhirov timurbazhirov deleted the feat/SOF-6873 branch September 16, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants