SOF-7293: [MD] Implement support for highlighting atoms in source/3D views #68
Conversation
There was a problem hiding this comment.
Not sure how the compiled files appeared to mismatch the TS version before. Not it is in sync.
| } | ||
| export default function Accordion({ hideExpandIcon, children, isExpanded, header, alternativeComponent, ...restProps }: AccordionProps): React.JSX.Element; | ||
| export default function Accordion({ hideExpandIcon, children, isExpanded, header, renderSummary, ...restProps }: AccordionProps): React.JSX.Element; |
There was a problem hiding this comment.
Did you commit the src? dist is updated automatically. Looks like the only changes there are to CodeMirror.tsx
There was a problem hiding this comment.
Correct. If we want to remove the .d.ts and .java from PRs, we have to remove those in repo and add them to .gitignore.
@timurbazhirov , lmn if want me to do so
There was a problem hiding this comment.
You need to modify files in src - https://github.com/Exabyte-io/cove.js/blob/main/src/mui/components/accordion/Accordion.tsx. dist is created in a pre-commit hook https://github.com/Exabyte-io/cove.js/blob/main/.husky/pre-commit
There was a problem hiding this comment.
We decided to commit dist to simplify installing packages from github commits. Just don't modify it directly.
sashafirsov
changed the title
CodeMirroronStatisticscallback progagated through. No functional changes.