small int + workaround for credentials #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusmacik
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Please if possible do not use the word "Workaround" in a parameter name or method.
matusmacik
reviewed
Oct 18, 2023
| Integer columnType = meta.getColumnType(i); | ||
| String columnTypeName = meta.getColumnTypeName(i); | ||
|
|
||
| if(meta.getColumnType(i) == 5) { |
There was a problem hiding this comment.
Type interpretation is handled in a separate project, the DB table connector has a dependency on. Please do not use this code snipped in this place and rather port this part of the contribution to the "https://github.com/Evolveum/connector-legacy-libs/tree/master/dbcommon" repository. You can use parts of the commit "Evolveum/connector-legacy-libs@6a80de7" as a reference fo the modifications needed for this.
|
Hello, thank you for the contribution. I added some comments to the code during the review. Please consider the changes and rebase and retest the changes. Thank you. |
…for multiple tables
# Conflicts: # connectors/java/databasetable/pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to contribute 2 minor changes: