Fixed Badeline last node crash

[nhruo123]

This PR fixes an issue where if the player this the last node of FinalBoss (Badeline) the game crashes.

Additinal details:
https://discord.com/channels/403698615446536203/1137280308887175178

[DemoJameson]

don't modify the OnPlayer(), since SJ il hook this method
maybe move your code into PushPlayer()

[nhruo123]

That could work, we could also patch it at the IL level and call some kind of static helper function to disply the card, not sure whats better.

[DemoJameson]

// we want to call LevelEnter.Go explicitly instant of letting CheckForErrors call it to prevent double triggers of postcard
LevelEnter.Go((Scene as Level).Session, false);

why the postcard will be triggered twice, since CheckForErrors only called once every frame

[nhruo123]

// we want to call LevelEnter.Go explicitly instant of letting CheckForErrors call it to prevent double triggers of postcard
LevelEnter.Go((Scene as Level).Session, false);

why the postcard will be triggered twice, since CheckForErrors only called once every frame

I used to set patch_LevelEnter.ErrorMessage at OnPlayer it was getting called after CheckForErrors consumed the error message somehow (I'll add a video that shows the issue), I didn't take the time to debug it and I just worked around it.

But now when its on PushPlayer that is called from Coroutine MoveSequence it does work, so it can be removed.

Is this behaviour with OnPlayer and patch_LevelEnter.ErrorMessage expected or should I debug it tomorrow?

(08/05/2023 21:51:11) [Everest] [Info] [LevelLoader] Loading bossfight
(08/05/2023 21:51:19) [Everest] [Warn] [FinalBoss] FinalBoss entity was hit on its last node, please add an additional node outside of the current room to ensure the player never hits it.
(08/05/2023 21:51:19) [Everest] [Warn] [FinalBoss] FinalBoss entity was hit on its last node, please add an additional node outside of the current room to ensure the player never hits it.
(08/05/2023 21:51:33) [Everest] [Info] [LevelLoader] Loading bossfight

output.mp4

[nhruo123]

Okay I figured out what's going on. it seems that even after CheckForErrors finds an error it keeps updating updating the level, so the state of patch_LevelEnter.ErrorMessage is as follows:

1. first update: patch_LevelEnter.ErrorMessage get set by OnPlayer
2. second update: patch_LevelEnter.ErrorMessage gets cleared but CheckForErrors
3. second update: patch_LevelEnter.ErrorMessage gets set again by a call to OnPlayer

then we leave the level with patch_LevelEnter.ErrorMessage already set.
I am not 100% sure about it but I feel like if we just stop updating the scene after we find an error at CheckForErrors it will work as expected, If it will I'll open a new PR for that.