refactor: Various tweaks for TAS Helper #112
Annotations
11 warnings
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Build:
CelesteTAS-EverestInterop/Source/Module/CelesteTasMenu.cs#L270
'EaseInSubMenu.ease' hides inherited member 'TextMenuExt.SubMenu.ease'. Use the new keyword if hiding was intended.
|
Build:
CelesteTAS-EverestInterop/Source/Utils/HookHelper.cs#L114
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
Build:
CelesteTAS-EverestInterop/Source/TAS/Input/Commands/ReadCommand.cs#L179
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
Build:
CelesteTAS-EverestInterop/Source/TAS/Input/Commands/AssertCommand.cs#L63
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
Build:
CelesteTAS-EverestInterop/Source/EverestInterop/ConsoleEnhancements.cs#L55
Don't call ILCursor.Remove or RemoveRange, as it can break other IL hooks which search for the removed instructions
|
Build:
CelesteTAS-EverestInterop/Source/EverestInterop/FastForwardBoost.cs#L38
Don't call ILCursor.Remove or RemoveRange, as it can break other IL hooks which search for the removed instructions
|
Build:
CelesteTAS-EverestInterop/Source/EverestInterop/Lua/EvalLuaCommand.cs#L54
Avoid passing lambdas to ILCursor.EmitDelegate, as it emits inefficient code. Pass a reference (method group) to a static method instead.
|
Build:
CelesteTAS-EverestInterop/Source/EverestInterop/Hitboxes/HitboxToggle.cs#L34
Don't call ILCursor.Remove or RemoveRange, as it can break other IL hooks which search for the removed instructions
|
Build:
CelesteTAS-EverestInterop/Source/EverestInterop/Hitboxes/HitboxSimplified.cs#L270
Avoid passing several predicates to ILCursor.(Try)Goto* methods, as other hooks might inject instructions between the target instructions. If possible, split them into separate calls instead.
|
Build:
CelesteTAS-EverestInterop/Source/EverestInterop/Hitboxes/HitboxSimplified.cs#L283
Don't call ILCursor.Remove or RemoveRange, as it can break other IL hooks which search for the removed instructions
|
Loading