Ignore incomplete entries in JSON 'run files map' caches #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsmt
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in
FileAccesswhere if we read a valid run files map withoutlegacy_sources, it wouldn't look at the files to identify legacy_sources.We have tried to be clever, by using the available information from the cache in such cases and getting the new information from the files. This has some performance benefit, because you read less from the files, but it means more complexity, creating bugs like this one. And we still have to open every file to read something from it.
So I think we should go with the simpler option, ignoring incomplete cache entries entirely, even if that is a bit slower.
[We should also extend it to allow caching runs from the
redfolder into scratch, but that's a separate question]cc @turkot @philsmt