Allow skipping specific checks in extra-data-validate #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| f'{pos + 1} ({ts[pos + 1]} < {ts[pos]})', | ||
| dataset=ds_path, | ||
| ) | ||
| for src, group in src_groups: |
Check notice
Code scanning / CodeQL
Nested loops with same variable Note
|
Thanks, I like this approach, as it allows a good level of granularity depending on the context the checks are run in. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial response to #503.
The idea is that
extra-data-validateis made up of a series of named checks, and you can pass e.g.--skip control_timestamps_orderto skip the check with that name. So far only the per-file checks can be controlled like this, but if we like the structure, we could add the per-directory checks (so far only one, checking the JSON cache).Specifically, the
@file_checkdecorator makes a function into a named check. The function name is reused as the check name (so we'll need to remember not to rename these functions too readily).