Allow selecting raw/proc data in components layer #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1630
to
+1814
| self.source_to_modno = {s: (m - first_modno + 1) | ||
| for (s, m) in self.source_to_modno.items()} |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning
| # JUNGFRAU modno is expected (e.g. extra_geom) to start with 1. | ||
| self.source_to_modno = {s: (m - first_modno + 1) | ||
| for (s, m) in self.source_to_modno.items()} | ||
| self.modno_to_source = {m: s for (s, m) in self.source_to_modno.items()} |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning
Closed
takluyver
force-pushed
the
feat/components-raw-proc
branch
from
ca4632f
to
f3e861c
Compare
takluyver
force-pushed
the
feat/components-raw-proc
branch
2 times, most recently
from
fcc832d
to
ac7240a
Compare
takluyver
force-pushed
the
feat/components-raw-proc
branch
from
ac7240a
to
26fa54d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for the future when raw & proc data has different names.
You can pass
raw=True,FalseorNone. The default isNone, which tries to preserve the legacy behaviour of using proc if possible and raw if not.Opening a draft PR to try the CI.