Expose units symbol & name on KeyData objects #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesWrigley
requested changes
Oct 5, 2023
JamesWrigley
requested changes
Oct 9, 2023
|
(oh, and this should probably be documented too) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Thanks! prnote: New properties |
|
LGTM! Some time ago I scanned over several runs and found only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As two new properties,
.unitsand.units_name. These combine the unit & metric prefix attributes written by Karabo to give symbols like 'μJ' or 'fs'. They will beNoneif these attributes aren't available. Pint recognises either the symbol or the name (for the couple of cases I tried).There's no caching at present. I assume people won't retrieve units many times for the same key, and the OS disk cache could help a bit anyway.