Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading data with webViewer #310

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix loading data with webViewer #310

merged 1 commit into from
Sep 11, 2024

Conversation

tmichela
Copy link
Member

@tmichela tmichela commented Aug 8, 2024

closes #308

@tmichela tmichela added the bug Something isn't working label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.36%. Comparing base (dde2dc0) to head (669dd7e).
Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
damnit/gui/main_window.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   74.39%   74.36%   -0.03%     
==========================================
  Files          32       32              
  Lines        4858     4861       +3     
==========================================
+ Hits         3614     3615       +1     
- Misses       1244     1246       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takluyver
Copy link
Member

It's probably fine, but do we understand what sandbox we're disabling here and what the potential consequences are?

@tmichela
Copy link
Member Author

the WebViewer uses chromium for rendering the web pages. This disables the sandbox for the chromium renderer.
I did not find any alternative to fixing that issue.

@takluyver
Copy link
Member

Following some discussion in chat, this should be fine, but @RobertRosca wanted to have a look into what's happening.

@tmichela
Copy link
Member Author

After having spent another fair amount of time (unsuccessfully) trying to fix that issue, and having confirmation from Robert that the risk implied by this change is very low... I'll merge later today if there are no objections.

@takluyver
Copy link
Member

Thanks, LGTM

@tmichela tmichela merged commit d672ff0 into master Sep 11, 2024
4 of 6 checks passed
@tmichela tmichela deleted the fix/webViewer branch September 11, 2024 13:44
@tmichela
Copy link
Member Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotly widget not showing figure
2 participants