Fix the instructions for connecting to XFELs broker offline #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we mean inside the DESY network? The control network is more restricted - I don't think it includes Maxwell. Other than that, LGTM. |
I'm not sure how this worked originally, but when testing it I found that the KafkaConsumer will connect to the bootstrap server (localhost) correctly with the AMORE_BROKER variable set, but it will then try to connect to exflwebstor01.desy.de and hang. I'm guessing that when it connects to the bootstrap server it gets a list of all brokers and then tries to connect to them; and since it sees localhost and exflwebstor01.desy.de as different brokers it'll try to connect to exflwebstor01.desy.de too.
|
Oops, yes you're quite right. Fixed in 30095dd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how this worked originally, but when testing it I found that the KafkaConsumer will connect to the bootstrap server (localhost) correctly with the AMORE_BROKER variable set, but it will then try to connect to exflwebstor01.desy.de and hang. I'm guessing that when it connects to the bootstrap server it gets a list of all brokers and then tries to connect to them; and since it sees localhost and exflwebstor01.desy.de as different brokers it'll try to connect to exflwebstor01.desy.de too.
(cherry-picked from one of my giant branches)