Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find run timestamps for runs with voview files #93

Open
JamesWrigley opened this issue Sep 15, 2023 · 0 comments
Open

Find run timestamps for runs with voview files #93

JamesWrigley opened this issue Sep 15, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@JamesWrigley
Copy link
Member

There are currently two ways to find the timestamp of the start of the run:

  • Use run.train_timestamps()
  • As a fallback for older runs that don't contain the train timestamps, use the creation timestamp of the RAW files

This is the code for the fallback:

if np.isnan(ts):

The problem occurs when an old run (without timestamps from the DAQ) is opened using a voview file, because then run.files will only contain that file, which will be ignored by DAMNIT because it's not in the raw/ directory, so the indexing on line 179 will fail. I think it's safe to assume that there'll always be at least one file behind a DataCollection, so maybe if only a voview file is present we should look at the files in the raw/ directory ourselves. Alternatively we could follow the links in the voview file but that seems a bit complicated given that we can fairly easily find the proposal directory.

Maybe in the future we can get the timestamps from mymdc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant