Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #8461: Add Toggle Hotkey and Pin Button for SFTP Panel #9786

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

GeminiLn
Copy link
Contributor

This PR addresses Issue #8461 by introducing two new features for the SFTP Panel:

  1. Toggle Hotkey:
  • Added a hotkey to toggle the visibility of the SFTP Panel, enhancing user convenience.
    Hotkey
  1. Pin Button:
  • Introduced a Pin button in the SFTP Panel. When activated, this button prevents the panel from closing when clicking outside of it, ensuring that the pinned panel remains open.
    Pin

@GeminiLn GeminiLn marked this pull request as draft July 13, 2024 00:48
@GeminiLn GeminiLn marked this pull request as ready for review July 13, 2024 01:22
@Eugeny
Copy link
Owner

Eugeny commented Jul 15, 2024

Thank you for contributing! In which case is it necessary to pin the panel?

Having to navigate to the current SFTP folder can be easily avoided by correctly setting up the CWD reporting, and the terminal in the background can't be currently properly used anyway while the panel is open.

@GeminiLn
Copy link
Contributor Author

Thank you for contributing! In which case is it necessary to pin the panel?

Having to navigate to the current SFTP folder can be easily avoided by correctly setting up the CWD reporting, and the terminal in the background can't be currently properly used anyway while the panel is open.

Issue #8461 did not specify when it is necessary to pin the panel. In my experience, I sometimes accidentally click outside the panel, causing it to close, which is quite annoying. I think adding a pin feature can prevent this.

And yes, I do notice that the terminal is unusable when the panel is open. I’m curious if it’s possible to adjust the panel to allow terminal use alongside SFTP. If this adjustment is feasible, I’d be willing to work on it sometime.

@Eugeny
Copy link
Owner

Eugeny commented Jul 16, 2024

TBF I think that would be a more viable improvement, as I don't quite see what this PR is solving (it's trivial to reopen the panel after closing it).

That would involve converting the SFTPPanel component into an SFTPTab and changing the SFTP button logic to instead opening a split pane (same as the "split > bottom" menu item) that would host the new SFTP tab sharing the same connection profile.

@barrelltitor
Copy link

For my workflow it's incredibly annoying to not have a pinned sidebar, would be great to be able to have both the terminal and the sftp pinned somehow, though a hotkey to open it would be great until then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants