forked from Adeptus-Dominus/ChapterMaster
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Data-driven psychic power system #74
Draft
EttyKitty
wants to merge
8
commits into
release/0.10.0.0
Choose a base branch
from
feat/psy-rework
base: release/0.10.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,245
−842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is still a crash with power_index going above power name array length.
EttyKitty
added
PR: Major Coding
Big enough to possibly clash with other PRs
PR: Refactor
Rewriting/restructuring code, while keeping general behaviour
PR: Balance
labels
Nov 4, 2024
@sourcery-ai review |
Reviewer's Guide by SourceryThis pull request reworks the psychic combat system by refactoring the power implementation and adjusting the Perils of the Warp mechanic. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EttyKitty - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a description of the functional changes this PR introduces. While the code changes look good, we need to understand how this affects gameplay.
- Consider adding comments explaining the perils calculation formula and other key gameplay mechanics to help future maintainers understand the design decisions.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
sourcery-ai
bot
changed the title
feat: @sourcery-ai
Refactor: Data-driven psychic power system
Dec 20, 2024
sourcery-ai
bot
changed the title
Refactor: Data-driven psychic power system
Refactor: Simplify power selection logic and standardize tome tags
Dec 20, 2024
EttyKitty
changed the title
Refactor: Simplify power selection logic and standardize tome tags
refactor: Data-driven psychic power system
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: Balance
PR: Major Coding
Big enough to possibly clash with other PRs
PR: Refactor
Rewriting/restructuring code, while keeping general behaviour
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will fill this later. For now, just to let others know that I'm doing/was doing this.
Partly I'm just trying to get better at coding, so it's very WIP and may or may not change drastically.
https://discord.com/channels/714022226810372107/1293320552743702549
Summary by Sourcery
Refactor power selection logic to use a data structure, simplifying the code and making it more maintainable. Standardize tome and daemonic artifact tags. Improve Perils of the Warp calculations and effects. Adjust UI elements and button sizes.
New Features:
Enhancements:
Tests: