Skip to content

Commit

Permalink
image builder: Fix error message for missing control SEP
Browse files Browse the repository at this point in the history
When attempting to generate an image core file with no control SEPs
(which is illegal), the image builder would throw an exception while
trying to produce the proper error message. The exception would look
like this:

File "[...]/site-packages/uhd/rfnoc_utils/builder_config.py", \
                                     line 330, in _check_configuration
    failures += [
TypeError: can only concatenate str (not "list") to str

This fixes the error, such that a regular error messages is shown now in
case of missing control SEPs.
  • Loading branch information
mbr0wn authored and joergho committed Nov 7, 2024
1 parent d30fde9 commit 5f38bb8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion host/python/uhd/rfnoc_utils/builder_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def _check_configuration(self):
self.log.debug("Running checks on the current configuration...")
failures = []
if not any(bool(sep["ctrl"]) for sep in self.stream_endpoints.values()):
failures = "At least one streaming endpoint needs to have ctrl enabled"
failures += ["At least one streaming endpoint needs to have ctrl enabled"]
# Check RFNoC protocol version. Use latest if it was not specified.
requested_version = self.rfnoc_version
[requested_major, requested_minor, *_] = requested_version.split(".")
Expand Down

0 comments on commit 5f38bb8

Please sign in to comment.