Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Python 3.10 #73

Closed
wants to merge 3 commits into from
Closed

Try Python 3.10 #73

wants to merge 3 commits into from

Conversation

bendichter
Copy link

@bendichter bendichter commented Aug 13, 2024


Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

@bendichter bendichter changed the title Update pyproject.toml Try Python 3.10 Aug 13, 2024
@bendichter
Copy link
Author

@vinicvaz I'm attempting to expand our environment to include Python 3.10 so this can be easily run on Google Colab I also think it's good to have this be able to run on more than a single version of Python if possible. The tests are failing but it looks like it might be just due to the way the tests were written. It looks like you may be using a newer feature of patch. Would it be possible to write these files without using patch? Maybe storing the config as a tempfile would be more straightforward?

@bendichter
Copy link
Author

@vinicvaz I've also modified the CI so that the tests run on PRs. This is the standard way to do it so you know if tests fail before you merge ;-)

@vinicvaz
Copy link
Collaborator

@bendichter if the problem is just the tests we can find a way to replace what are conflictant. I don't think removing the patch mocks to a config file is a good options,, there are some tests we need to override some settings or arguments on the fly to make.
I don't know why but my github is not showing the entire logs in the actions (as shown in the image below) so I didn't see what exactly is failing. Can you see the entire log?

image

@vinicvaz
Copy link
Collaborator

@bendichter about the CI, great, thanks for fixing this. If I'm not wrong we were running the tests only from dev because of the github 2000 minutes / month limit for free accounts. When we were actively commiting on multiple branches we could potentially reach this limit since the tests can take some time to run and we have 3 OS to test.

@bendichter
Copy link
Author

bendichter commented Aug 14, 2024

@vinicvaz the 2,000 minute limit is for private repositories. There is no limit for public repositories (source)

GitHub Actions usage is free for standard GitHub-hosted runners in public repositories, and for self-hosted runners. For private repositories, each GitHub account receives a certain amount of free minutes and storage for use with GitHub-hosted runners, depending on the account's plan.

@bendichter
Copy link
Author

Also, I emailed you the console output because I think it's too long to post here

@luiztauffer
Copy link
Collaborator

the reason why Python 3.10 was requested is because that is the default version in Google Colab. But this is about to change: googlecolab/colabtools#4935

I suggest we keep supporting Python >= 3.11

@luiztauffer luiztauffer closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants