-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try Python 3.10 #73
Try Python 3.10 #73
Conversation
bendichter
commented
Aug 13, 2024
•
edited by katiekly
Loading
edited by katiekly
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1208161143099980
- https://app.asana.com/0/0/1208161143099988
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
@vinicvaz I'm attempting to expand our environment to include Python 3.10 so this can be easily run on Google Colab I also think it's good to have this be able to run on more than a single version of Python if possible. The tests are failing but it looks like it might be just due to the way the tests were written. It looks like you may be using a newer feature of |
@vinicvaz I've also modified the CI so that the tests run on PRs. This is the standard way to do it so you know if tests fail before you merge ;-) |
@bendichter if the problem is just the tests we can find a way to replace what are conflictant. I don't think removing the patch mocks to a config file is a good options,, there are some tests we need to override some settings or arguments on the fly to make. |
@bendichter about the CI, great, thanks for fixing this. If I'm not wrong we were running the tests only from dev because of the github 2000 minutes / month limit for free accounts. When we were actively commiting on multiple branches we could potentially reach this limit since the tests can take some time to run and we have 3 OS to test. |
@vinicvaz the 2,000 minute limit is for private repositories. There is no limit for public repositories (source)
|
Also, I emailed you the console output because I think it's too long to post here |
the reason why Python 3.10 was requested is because that is the default version in Google Colab. But this is about to change: googlecolab/colabtools#4935 I suggest we keep supporting Python >= 3.11 |