Increase CAS_LEN_NETID to 320 (email address max length) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok to increase... but the rationale seems wrong according to https://stackoverflow.com/a/574698/3005203 which says 254 is the max for email address. |
|
Ok, sorry. I didn't see the restriction of 254 characters for the full email address lenght. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We used pam_cas for SSO with dovecot server. We use emails addresses as login.
Email addresses longer than CAS_LEN_NETID will be truncate and login failed.
320 is the limit for email addresse length defined in the RFC.