Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Fix links for accessibility #924

Merged
merged 13 commits into from
Aug 30, 2023
Merged

[DONE] Fix links for accessibility #924

merged 13 commits into from
Aug 30, 2023

Conversation

AymericJak
Copy link
Collaborator

@AymericJak AymericJak commented Aug 29, 2023 •
edited
Loading

RGAA 6.1

  • Amélioration header & footer.
  • Suppression du role="button" sur le bouton Afficher toutes les vidéos, jugé inapproprié (page d'accueil).
  • Modification du dernier bouton (logo) dans la barre d'action du player d'une vidéo. --> Le devient un .
  • Changement du title de plusieurs boutons.

Modification d'un paramètre dans le context_processor !

Modification du LINK_PLAYER. Celui-ci devient désormais un tuple : (lien_de_redirection, "Intitulé de la page de redirection")

@AymericJak AymericJak added the enhancement New feature or request label Aug 29, 2023
@AymericJak AymericJak self-assigned this Aug 29, 2023
@AymericJak AymericJak changed the title [WIP] Fix links for accessibility [DONE] Fix links for accessibility Aug 30, 2023
@AymericJak AymericJak marked this pull request as ready for review August 30, 2023 13:02
ptitloup
ptitloup reviewed Aug 30, 2023
View reviewed changes
pod/chapter/templates/video_chapter.html Show resolved Hide resolved
pod/cut/templates/video_cut.html Show resolved Hide resolved
pod/live/templates/live/direct.html Outdated Show resolved Hide resolved
pod/live/templates/live/event-script.html Outdated Show resolved Hide resolved
pod/main/configuration.json Outdated Show resolved Hide resolved
pod/main/context_processors.py Outdated Show resolved Hide resolved
pod/video/templates/videos/video_collaborate.html Show resolved Hide resolved
pod/video/templates/videos/video_delete.html Show resolved Hide resolved
Badatos
Badatos requested changes Aug 30, 2023
View reviewed changes
pod/live/templates/live/event-script.html Outdated
linktitle: '{{TITLE_ETB}}"-"{{TITLE_SITE}}',
link: '{{LINK_PLAYER}}'
});
player.videoJsLogo({imgsrc: '{% static LOGO_PLAYER %}', linktitle:'{{ TITLE_SITE }} - {% if LINK_PLAYER.1 %}{{ LINK_PLAYER.1 }}{% else %}{% trans "Home" %}{% endif %} - {% trans "New window" %}', link:'{{ LINK_PLAYER.0 }}'});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je trouve que c'était plus lisible sur 3 lignes, mais je chipote ;)

pod/locale/fr/LC_MESSAGES/django.po Outdated
msgstr "Partager ce dossier"
#, python-format
msgid "Share folder “%(folder_name)s” with somebody"
msgstr "Partager le dossier « %(folder_name)s » avec quelqu’un"
Copy link
Collaborator

@Badatos Badatos Aug 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est vraiment plus clair de rajouter "avec quelqu'un" ? des fois je suis dubitatif de certains conseils d'accessibilité...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour le coup, ça vient de moi.

En fait, en appuyant sur le bouton, je m'attendais à avoir une modale, avec une possibilité de partager par je ne sais quelle manière (via réseaux sociaux ou autre).

Mais nous ne pouvons partager qu'avec un membre de la plateforme. Donc je me suis dit de rajouter ce fameux "quelqu'un"

pod/main/configuration.json Outdated Show resolved Hide resolved
pod/main/templates/footer.html Outdated
@@ -31,6 +31,8 @@
</ul>
</div>
</div>
<p class="hidden-pod pod-footer__credits" style="text-align:center">{{TITLE_SITE}} {% trans "video platform of" %} {{TITLE_ETB}} - <a href="https://github.com/EsupPortail/Esup-Pod/releases/tag/{{VERSION}}" target="_blank" title="GitHub">{% trans "Release" %} {{VERSION}}</a> - {{VIDEOS_COUNT}} {% trans "videos availables" %} [ {{VIDEOS_DURATION}} ]</p>
<p class="hidden-pod pod-footer__credits" style="text-align:center">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remplacer style="text-align:center" par class="text-center"

pod/main/templates/footer.html Outdated
@@ -31,6 +31,8 @@
</ul>
</div>
</div>
<p class="hidden-pod pod-footer__credits" style="text-align:center">{{TITLE_SITE}} {% trans "video platform of" %} {{TITLE_ETB}} - <a href="https://github.com/EsupPortail/Esup-Pod/releases/tag/{{VERSION}}" target="_blank" title="GitHub">{% trans "Release" %} {{VERSION}}</a> - {{VIDEOS_COUNT}} {% trans "videos availables" %} [ {{VIDEOS_DURATION}} ]</p>
<p class="hidden-pod pod-footer__credits" style="text-align:center">
{{TITLE_SITE}} {% trans "video platform of" %} {{TITLE_ETB}} - <a href="https://github.com/EsupPortail/Esup-Pod/releases/tag/{{VERSION}}" target="_blank" title="{% trans "View changes to version" %} {{ VERSION }} {% trans "on" %} GitHub">{% trans "Release" %} {{VERSION}}</a> - {{VIDEOS_COUNT}} {% trans "videos availables" %} [ {{VIDEOS_DURATION}} ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'aurais plutôt mis "View changes of version"

pod/main/templates/navbar.html Outdated
@@ -17,7 +17,7 @@
aria-controls="pod-navbar__menu" title="{% trans 'Toggle navigation' %}">
<i class="bi bi-list" aria-hidden="true"></i>
</button>
<a class="navbar-brand pod-navbar__brand me-0 me-sm-1" href="/">
<a class="navbar-brand pod-navbar__brand me-0 me-sm-1" href="/" aria-label="{{ TITLE_SITE }} - {% trans 'Home' %}" {% if request.path == '/' %}aria-current="page"{% endif %}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plutot qu'un aria-label, j'aurai mis un "title" pour que tout le monde en profite ^^
(en plus avec un title on voit plus rapidement s'il y a un souci, ce qui est mieux aussi pour les mal voyants ^^)

ptitloup
ptitloup approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi

Badatos
Badatos approved these changes Aug 30, 2023
View reviewed changes
pod/live/templates/live/event-script.html Outdated
@@ -105,8 +105,8 @@

player.videoJsLogo({
imgsrc: '{% static LOGO_PLAYER %}',
linktitle: '{{TITLE_ETB}}"-"{{TITLE_SITE}}',
link: '{{LINK_PLAYER}}'
linktitle:'{{ TITLE_SITE }} - {% if LINK_PLAYER_NAME %}{{ LINK_PLAYER_NAME }}{% else %}{% trans "Home" %}{% endif %} - {% trans "New window" %}',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il y a bien un espace apres les signes de ponctuation double en anglais, pas besoin de les retirer ^^.

pod/locale/fr/LC_MESSAGES/django.po Outdated
msgstr "Supprimer l’enrichissement"
#, python-format
msgid "Modify the enrichment “%(enrich_title)s”"
msgstr "Modifier l'enrichissement « %(enrich_title)s »"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l'apostrophe avant enrichissement n'est pas la bonne (voir ligne 2128 pour la bonne)

@ptitloup ptitloup merged commit fa5cf0a into EsupPortail:develop Aug 30, 2023
3 of 4 checks passed
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 22, 2023
@AymericJak @vsabatie
[DONE] Fix links for accessibility (EsupPortail#924)
3a03ce3 
* Change header & footer titles

* Change logo button in video player

* Change some translations

* Change LINK_PLAYER setting and link of logo in player

* Change title for buttons

* Remove redundant button

* Change files location

* Add LINK_PLAYER_NAME parameter

* Fix some translations

* Fix

* Last fix
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 23, 2023
@AymericJak @vsabatie
[DONE] Fix links for accessibility (EsupPortail#924)
a80af86 
* Change header & footer titles

* Change logo button in video player

* Change some translations

* Change LINK_PLAYER setting and link of logo in player

* Change title for buttons

* Remove redundant button

* Change files location

* Add LINK_PLAYER_NAME parameter

* Fix some translations

* Fix

* Last fix
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 23, 2023
@AymericJak @vsabatie
[DONE] Fix links for accessibility (EsupPortail#924)
e0c44a5 
* Change header & footer titles

* Change logo button in video player

* Change some translations

* Change LINK_PLAYER setting and link of logo in player

* Change title for buttons

* Remove redundant button

* Change files location

* Add LINK_PLAYER_NAME parameter

* Fix some translations

* Fix

* Last fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitloup ptitloup ptitloup approved these changes

@Badatos Badatos Badatos approved these changes

@SebastienCozeDev SebastienCozeDev SebastienCozeDev approved these changes

Assignees

@AymericJak AymericJak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AymericJak @ptitloup @Badatos @SebastienCozeDev