[DONE] Pampletousse/fix accomodation years date delete #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EsupPortail#3.3.0 - Import external video from url, youtube, peertube and BigBlueButton - Change xapi actor to deal with Moodle - Update template to BS5.3 and improve compliance for W3C - Use redis to cache session and improve logging - refactor of encoding/transcripting to move it in separate application - Fixbug on categories, recorder, user liste, tags cloud
[DONE] Develop EsupPortail#3.3.1
pampletousse
changed the title
Badatos
approved these changes
Aug 28, 2023
pampletousse
changed the title
|
Les tests ne passent plus j'essaie de les réparer mais en ce qui concerne le fonctionnel à priori c'est bon |
…ause to multiples affiliations per users)
pampletousse
force-pushed
the
pampletousse/fix-accomodation_years_date_delete
branch
from
aba9dab
to
4314c51
Compare
…f string OR simple string
pampletousse
commented
Sep 13, 2023
|
Au fait, tous les test unitaires passent maintenant. |
AymericJak
approved these changes
Sep 18, 2023
|
Est-ce possible de passer cette PR en DONE ? Merci |
pampletousse
changed the title
AymericJak
approved these changes
Sep 18, 2023
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Nov 22, 2023
* Fix date_delete setup with accommodation years (not correctly setup cause to multiples affiliations per users) * Add verification for user affiliation to pass tests * Fix bad parenthesis * Add verification on affiliation_years result to pass test * Update test with new working new_year calculation * Fix tests and save video obsolescence to handle affiliation : array of string OR simple string * Try fixing Flake8 complexity * Add pydoc for new function get_date_delete_for_affiliation * Decompose function to test affiliation, add pydoc --------- Co-authored-by: Ptitloup <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix de la date de suppression non calquée sur les années d'obsolescences par affiliation définies dans ACCOMMODATION_YEARS. A cause de users dont la value affiliation est parfois une string, parfois un tableau de valeur