-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONE] Fix : Accessibility for the media compatibility with the assistive tools (04.13) #919
Conversation
Merci pour cette nouvelle PR :) Au passage, qui est l'auteur de l'image default-playlist.svg ? pod/playlist/static/playlist/img/default-playlist.svg Il faudra l'indiquer ainsi que la licence dans les crédits de Pod. |
…compatibility_with_assistive_tools
…compatibility_with_assistive_tools
…compatibility_with_assistive_tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le code semble correct.
Je n'ai pas testé localement.
Juste une interrogation sur 2 traductions.
À voir si mes propositions sont assez claires / cohérentes.
Je suis d'accord avec la remarque de Aymeric. J'aurais egalement mis "avancer de 10 seconde dans la vidéo" et "reculer de 10 secondes dans la vidéos" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok pour moi, merci !
|
||
#: pod/video/static/js/video-show.js | ||
msgid "Seek forward 10 seconds in the video" | ||
msgstr "Avancer de 10 secondes dans le video" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo : LA vidéo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est réglé
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est tout bon pour moi !
Merci :)
…tive tools (04.13) (EsupPortail#919) * Add video-show.js for the button translation * Fix the chapter modal * Add the aria-label attribute in the reset track settings button * Translate * Update titles for seek forward & seek back buttons * Fix translation * Fix translation
…tive tools (04.13) (EsupPortail#919) * Add video-show.js for the button translation * Fix the chapter modal * Add the aria-label attribute in the reset track settings button * Translate * Update titles for seek forward & seek back buttons * Fix translation * Fix translation
…tive tools (04.13) (EsupPortail#919) * Add video-show.js for the button translation * Fix the chapter modal * Add the aria-label attribute in the reset track settings button * Translate * Update titles for seek forward & seek back buttons * Fix translation * Fix translation
Before sending your pull request, make sure the following are done :
develop
branch.[WIP]
or[DONE]
.Non-conformité :
Piste de correction :
Dans le dépliant : supprimer le role="menu", attribuer à chaque un role="button" et le rendre activable avec les touches Entrée et Espace, et ajouter sur l’élément non focusable un tabindex="0"